Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of function to refer to root schema instead of element item schema; move filter addition to init function #1768

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Dec 23, 2024

No description provided.

@westonruter westonruter added this to the image-prioritizer n.e.x.t milestone Dec 23, 2024
@westonruter westonruter added [Type] Bug An existing feature is broken [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) labels Dec 23, 2024
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@westonruter westonruter force-pushed the fix/misc-od-plugin-nits branch from 2ea897a to efd544f Compare January 9, 2025 21:11
Comment on lines -14 to -16
add_filter( 'od_extension_module_urls', 'image_prioritizer_filter_extension_module_urls' );
add_filter( 'od_url_metric_schema_root_additional_properties', 'image_prioritizer_add_element_item_schema_properties' );
add_filter( 'rest_request_before_callbacks', 'image_prioritizer_filter_rest_request_before_callbacks', 10, 3 );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to plugins/image-prioritizer/helper.php

@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label Jan 9, 2025
@westonruter westonruter changed the title Fix name of Image Prioritizer function (among other nits) Fix name of function to refer to root schema instead of element item schema; move filter addition to init function Jan 9, 2025
@westonruter westonruter marked this pull request as ready for review January 9, 2025 21:20
Copy link

github-actions bot commented Jan 9, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter merged commit 4693bee into trunk Jan 9, 2025
26 checks passed
@westonruter westonruter deleted the fix/misc-od-plugin-nits branch January 9, 2025 21:20
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.42%. Comparing base (dde008b) to head (efd544f).
Report is 14 commits behind head on trunk.

Files with missing lines Patch % Lines
plugins/image-prioritizer/helper.php 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            trunk    #1768      +/-   ##
==========================================
+ Coverage   57.38%   57.42%   +0.04%     
==========================================
  Files          84       84              
  Lines        6504     6506       +2     
==========================================
+ Hits         3732     3736       +4     
+ Misses       2772     2770       -2     
Flag Coverage Δ
multisite 57.42% <80.00%> (+0.04%) ⬆️
single 34.47% <80.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Image Prioritizer Issues for the Image Prioritizer plugin (dependent on Optimization Detective) skip changelog PRs that should not be mentioned in changelogs [Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants